Parcourir la source

fix(tui): make migrated selected background transparent

James Long il y a 3 semaines
Parent
commit
a9295fae32

+ 1 - 1
packages/tui/src/theme/v2/v1-migrate.ts

@@ -98,7 +98,7 @@ function migrateMode(theme: Theme, mode: Mode): FileThemeDefinition {
         overlay: backgroundMenu,
       },
       action: {
-        primary: { default: "transparent", $hovered: backgroundPanel, $focused: primary, $selected: primary },
+        primary: { default: "transparent", $hovered: backgroundPanel, $focused: primary, $selected: "transparent" },
         destructive: { default: color("error") },
       },
       formfield: {

+ 2 - 2
packages/tui/test/theme/v2/v1-migrate.test.ts

@@ -28,7 +28,7 @@ test("migrates resolved V1 modes into literal V2 tokens", () => {
   expect(migrated.dark.background?.surface?.offset).toBe("$hue.neutral.700")
   expect(migrated.dark.background?.surface?.overlay).toBe("$hue.neutral.600")
   expect(migrated.light.text?.action?.primary?.default).toBe("$text.default")
-  expect(migrated.light.background?.action?.primary?.$selected).toBe("$hue.interactive.800")
+  expect(migrated.light.background?.action?.primary?.$selected).toBe("transparent")
   expect(migrated.light.scrollbar?.default).toBe(hex(legacy.borderActive))
   expect(migrated.light.diff?.lineNumber?.background?.removed).toBe(hex(legacy.diffRemovedLineNumberBg))
   expect(migrated.light.markdown?.emphasis).toBe(hex(legacy.markdownEmph))
@@ -41,7 +41,7 @@ test("migrates resolved V1 modes into literal V2 tokens", () => {
   expect(resolved.text.formfield.focused.toInts()).toEqual(legacy.primary.toInts())
   expect(resolved.hue.accent[800].toInts()).toEqual(legacy.accent.toInts())
   expect(resolved.hue.interactive[800].toInts()).toEqual(legacy.primary.toInts())
-  expect(resolved.background.action.primary.selected.toInts()).toEqual(legacy.primary.toInts())
+  expect(resolved.background.action.primary.selected.toInts()).toEqual([0, 0, 0, 0])
   expect(resolved.text.action.primary.selected.toInts()).toEqual(legacy.primary.toInts())
   expect(resolved.background.feedback.error.default.toInts()).toEqual(legacy.background.toInts())
   expect(resolved.contexts["@context:elevated"]?.background.default.toInts()).toEqual(legacy.backgroundPanel.toInts())