permission.test.ts 12 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300
  1. import { describe, expect } from "bun:test"
  2. import { Deferred, Effect, Fiber, Layer } from "effect"
  3. import { AgentV2 } from "@opencode-ai/core/agent"
  4. import { Database } from "@opencode-ai/core/database/database"
  5. import { EventV2 } from "@opencode-ai/core/event"
  6. import { Location } from "@opencode-ai/core/location"
  7. import { PermissionV2 } from "@opencode-ai/core/permission"
  8. import { PermissionTable } from "@opencode-ai/core/permission/sql"
  9. import { PermissionSaved } from "@opencode-ai/core/permission/saved"
  10. import { Project } from "@opencode-ai/core/project"
  11. import { ProjectTable } from "@opencode-ai/core/project/sql"
  12. import { AbsolutePath } from "@opencode-ai/core/schema"
  13. import { SessionV2 } from "@opencode-ai/core/session"
  14. import { SessionTable } from "@opencode-ai/core/session/sql"
  15. import { SessionExecution } from "@opencode-ai/core/session/execution"
  16. import { SessionStore } from "@opencode-ai/core/session/store"
  17. import { eq } from "drizzle-orm"
  18. import { location } from "./fixture/location"
  19. import { testEffect } from "./lib/effect"
  20. const current = Layer.succeed(
  21. Location.Service,
  22. Location.Service.of(location({ directory: AbsolutePath.make("/project") })),
  23. )
  24. const sessions = SessionV2.layer.pipe(
  25. Layer.provide(EventV2.defaultLayer),
  26. Layer.provide(Database.defaultLayer),
  27. Layer.provide(SessionStore.defaultLayer),
  28. Layer.provide(Project.defaultLayer),
  29. Layer.provide(SessionExecution.noopLayer),
  30. )
  31. const layer = PermissionV2.locationLayer.pipe(
  32. Layer.provideMerge(Database.defaultLayer),
  33. Layer.provideMerge(SessionStore.defaultLayer),
  34. Layer.provideMerge(EventV2.defaultLayer),
  35. Layer.provideMerge(current),
  36. Layer.provideMerge(sessions),
  37. Layer.provideMerge(SessionExecution.noopLayer),
  38. Layer.provideMerge(PermissionSaved.defaultLayer),
  39. )
  40. const it = testEffect(layer)
  41. function setup(rules: PermissionV2.Ruleset = []) {
  42. return Effect.gen(function* () {
  43. const { db } = yield* Database.Service
  44. yield* db
  45. .insert(ProjectTable)
  46. .values({ id: Project.ID.global, worktree: AbsolutePath.make("/project"), sandboxes: [] })
  47. .onConflictDoNothing()
  48. .run()
  49. .pipe(Effect.orDie)
  50. yield* db
  51. .insert(SessionTable)
  52. .values({
  53. id: SessionV2.ID.make("ses_test"),
  54. project_id: Project.ID.global,
  55. slug: "test",
  56. directory: "/project",
  57. title: "test",
  58. version: "test",
  59. agent: "test",
  60. })
  61. .onConflictDoNothing()
  62. .run()
  63. .pipe(Effect.orDie)
  64. yield* setRules(rules)
  65. })
  66. }
  67. function setRules(rules: PermissionV2.Ruleset) {
  68. return Effect.gen(function* () {
  69. const agents = yield* AgentV2.Service
  70. yield* agents.transform((editor) =>
  71. editor.update(AgentV2.ID.make("test"), (agent) => {
  72. agent.permissions = [...rules]
  73. }),
  74. )
  75. })
  76. }
  77. function assertion(input: Partial<PermissionV2.AssertInput> = {}) {
  78. return {
  79. id: PermissionV2.ID.create("per_test"),
  80. sessionID: SessionV2.ID.make("ses_test"),
  81. action: "read",
  82. resources: ["src/index.ts"],
  83. ...input,
  84. } satisfies PermissionV2.AssertInput
  85. }
  86. function waitForRequest() {
  87. return Effect.gen(function* () {
  88. const service = yield* PermissionV2.Service
  89. const events = yield* EventV2.Service
  90. const asked = yield* Deferred.make<PermissionV2.Request>()
  91. const unsubscribe = yield* events.listen((event) =>
  92. event.type === PermissionV2.Event.Asked.type
  93. ? Deferred.succeed(asked, event.data as PermissionV2.Request).pipe(Effect.asVoid)
  94. : Effect.void,
  95. )
  96. yield* Effect.addFinalizer(() => unsubscribe)
  97. const fiber = yield* service.assert(assertion()).pipe(Effect.forkScoped)
  98. const request = yield* Deferred.await(asked)
  99. return { service, fiber, request }
  100. })
  101. }
  102. describe("PermissionV2", () => {
  103. it.effect("returns the evaluated effect and only queues prompts", () =>
  104. Effect.gen(function* () {
  105. yield* setup([{ action: "read", resource: "*", effect: "allow" }])
  106. const service = yield* PermissionV2.Service
  107. expect(yield* service.ask(assertion())).toEqual({ id: PermissionV2.ID.create("per_test"), effect: "allow" })
  108. expect(yield* service.list()).toEqual([])
  109. yield* setRules([{ action: "read", resource: "*", effect: "deny" }])
  110. expect(yield* service.ask(assertion())).toEqual({ id: PermissionV2.ID.create("per_test"), effect: "deny" })
  111. expect(yield* service.list()).toEqual([])
  112. yield* setRules([])
  113. expect(yield* service.ask(assertion())).toEqual({ id: PermissionV2.ID.create("per_test"), effect: "ask" })
  114. expect(yield* service.get(PermissionV2.ID.create("per_test"))).toBeDefined()
  115. }),
  116. )
  117. it.effect("evaluates against an explicit provider-turn agent", () =>
  118. Effect.gen(function* () {
  119. yield* setup([{ action: "read", resource: "*", effect: "allow" }])
  120. const agents = yield* AgentV2.Service
  121. yield* agents.transform((editor) =>
  122. editor.update(AgentV2.ID.make("reviewer"), (agent) => {
  123. agent.permissions.push({ action: "read", resource: "*", effect: "deny" })
  124. }),
  125. )
  126. const service = yield* PermissionV2.Service
  127. expect(yield* service.ask(assertion())).toMatchObject({ effect: "allow" })
  128. expect(yield* service.ask(assertion({ agent: AgentV2.ID.make("reviewer") }))).toMatchObject({ effect: "deny" })
  129. yield* agents.transform((editor) =>
  130. editor.update(AgentV2.ID.make("reviewer"), (agent) => {
  131. agent.permissions = []
  132. }),
  133. )
  134. expect(yield* service.ask(assertion({ agent: AgentV2.ID.make("reviewer") }))).toMatchObject({ effect: "ask" })
  135. expect(yield* service.get(PermissionV2.ID.create("per_test"))).not.toHaveProperty("agent")
  136. }),
  137. )
  138. it.effect("allows and denies from explicit rules without asking", () =>
  139. Effect.gen(function* () {
  140. yield* setup([{ action: "read", resource: "*", effect: "allow" }])
  141. const service = yield* PermissionV2.Service
  142. yield* service.assert(assertion())
  143. yield* setRules([{ action: "read", resource: "*", effect: "deny" }])
  144. const denied = yield* service.assert(assertion()).pipe(Effect.flip)
  145. expect(denied).toBeInstanceOf(PermissionV2.DeniedError)
  146. expect(yield* service.list()).toEqual([])
  147. }),
  148. )
  149. it.effect("allows managed output reads without granting external directory access", () =>
  150. Effect.gen(function* () {
  151. yield* setup([
  152. { action: "*", resource: "*", effect: "deny" },
  153. { action: "read", resource: "*", effect: "allow" },
  154. ])
  155. const service = yield* PermissionV2.Service
  156. expect(yield* service.ask(assertion({ resources: ["tool_123"] }))).toMatchObject({ effect: "allow" })
  157. expect(
  158. yield* service.ask(assertion({ action: "external_directory", resources: ["/tmp/tool-output/*"] })),
  159. ).toMatchObject({ effect: "deny" })
  160. }),
  161. )
  162. it.effect("uses build permissions when the Session agent is omitted", () =>
  163. Effect.gen(function* () {
  164. yield* setup()
  165. const { db } = yield* Database.Service
  166. yield* db
  167. .update(SessionTable)
  168. .set({ agent: null })
  169. .where(eq(SessionTable.id, SessionV2.ID.make("ses_test")))
  170. .run()
  171. .pipe(Effect.orDie)
  172. const agents = yield* AgentV2.Service
  173. yield* agents.transform((editor) =>
  174. editor.update(AgentV2.ID.make("build"), (agent) => {
  175. agent.permissions = [{ action: "todowrite", resource: "*", effect: "allow" }]
  176. }),
  177. )
  178. const service = yield* PermissionV2.Service
  179. expect(yield* service.ask(assertion({ action: "todowrite", resources: ["*"] }))).toEqual({
  180. id: PermissionV2.ID.create("per_test"),
  181. effect: "allow",
  182. })
  183. expect(yield* service.list()).toEqual([])
  184. }),
  185. )
  186. it.effect("denies omitted-agent permissions when no primary default agent exists", () =>
  187. Effect.gen(function* () {
  188. yield* setup()
  189. const { db } = yield* Database.Service
  190. yield* db
  191. .update(SessionTable)
  192. .set({ agent: null })
  193. .where(eq(SessionTable.id, SessionV2.ID.make("ses_test")))
  194. .run()
  195. .pipe(Effect.orDie)
  196. const agents = yield* AgentV2.Service
  197. yield* agents.transform((editor) => {
  198. editor.remove(AgentV2.ID.make("test"))
  199. editor.remove(AgentV2.ID.make("build"))
  200. })
  201. const service = yield* PermissionV2.Service
  202. expect(yield* service.ask(assertion())).toEqual({ id: PermissionV2.ID.create("per_test"), effect: "deny" })
  203. expect(yield* service.list()).toEqual([])
  204. }),
  205. )
  206. it.effect("evaluates bash with the normal configured-rule semantics", () =>
  207. Effect.gen(function* () {
  208. yield* setup([{ action: "*", resource: "*", effect: "allow" }])
  209. const service = yield* PermissionV2.Service
  210. const bash = assertion({ action: "bash", resources: ["pwd"] })
  211. expect(yield* service.ask(bash)).toEqual({ id: PermissionV2.ID.create("per_test"), effect: "allow" })
  212. yield* setRules([])
  213. expect(yield* service.ask(bash)).toEqual({ id: PermissionV2.ID.create("per_test"), effect: "ask" })
  214. expect(yield* service.get(PermissionV2.ID.create("per_test"))).toBeDefined()
  215. }),
  216. )
  217. it.effect("uses saved bash approvals while preserving configured deny precedence", () =>
  218. Effect.gen(function* () {
  219. yield* setup()
  220. const saved = yield* PermissionSaved.Service
  221. yield* saved.add({ projectID: Project.ID.global, action: "bash", resources: ["pwd"] })
  222. const service = yield* PermissionV2.Service
  223. expect(yield* service.ask(assertion({ action: "bash", resources: ["pwd"] }))).toEqual({
  224. id: PermissionV2.ID.create("per_test"),
  225. effect: "allow",
  226. })
  227. expect(yield* service.list()).toEqual([])
  228. yield* setRules([{ action: "bash", resource: "*", effect: "deny" }])
  229. expect(yield* service.ask(assertion({ action: "bash", resources: ["pwd"] }))).toEqual({
  230. id: PermissionV2.ID.create("per_test"),
  231. effect: "deny",
  232. })
  233. }),
  234. )
  235. it.effect("resolves an asked permission once", () =>
  236. Effect.gen(function* () {
  237. yield* setup()
  238. const { service, fiber, request } = yield* waitForRequest()
  239. expect(yield* service.list()).toEqual([request])
  240. expect(yield* service.forSession(request.sessionID)).toEqual([request])
  241. expect(yield* service.forSession(SessionV2.ID.make("ses_other"))).toEqual([])
  242. expect(yield* service.get(request.id)).toEqual(request)
  243. yield* service.reply({ requestID: request.id, reply: "once" })
  244. yield* Fiber.join(fiber)
  245. expect(yield* service.list()).toEqual([])
  246. expect(yield* service.get(request.id)).toBeUndefined()
  247. }),
  248. )
  249. it.effect("stores and removes saved resources for a project", () =>
  250. Effect.gen(function* () {
  251. yield* setup()
  252. const service = yield* PermissionV2.Service
  253. const asked = yield* Deferred.make<PermissionV2.Request>()
  254. const events = yield* EventV2.Service
  255. const unsubscribe = yield* events.listen((event) =>
  256. event.type === PermissionV2.Event.Asked.type
  257. ? Deferred.succeed(asked, event.data as PermissionV2.Request).pipe(Effect.asVoid)
  258. : Effect.void,
  259. )
  260. yield* Effect.addFinalizer(() => unsubscribe)
  261. const fiber = yield* service.assert(assertion({ save: ["src/*"] })).pipe(Effect.forkScoped)
  262. const request = yield* Deferred.await(asked)
  263. yield* service.reply({ requestID: request.id, reply: "always" })
  264. yield* Fiber.join(fiber)
  265. const { db } = yield* Database.Service
  266. expect(
  267. yield* db.select().from(PermissionTable).where(eq(PermissionTable.project_id, Project.ID.global)).all(),
  268. ).toMatchObject([{ action: "read", resource: "src/*" }])
  269. const saved = yield* PermissionSaved.Service
  270. const id = (yield* saved.list())[0]!.id
  271. expect(yield* saved.list()).toEqual([{ id, projectID: Project.ID.global, action: "read", resource: "src/*" }])
  272. yield* service.assert(assertion({ id: PermissionV2.ID.create("per_next"), resources: ["src/next.ts"] }))
  273. yield* saved.remove(id)
  274. expect(yield* saved.list()).toEqual([])
  275. }),
  276. )
  277. })