permission.test.ts 12 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316
  1. import { describe, expect } from "bun:test"
  2. import { Cause, Deferred, Effect, Fiber, Layer } from "effect"
  3. import { Agent } from "@opencode-ai/core/agent"
  4. import { Database } from "@opencode-ai/core/database/database"
  5. import { AppNodeBuilder } from "@opencode-ai/core/effect/app-node-builder"
  6. import { LayerNode } from "@opencode-ai/util/effect/layer-node"
  7. import { Bus } from "@opencode-ai/core/bus"
  8. import { Job } from "@opencode-ai/core/job"
  9. import { Location } from "@opencode-ai/core/location"
  10. import { Permission } from "@opencode-ai/core/permission"
  11. import { PermissionTable } from "@opencode-ai/core/permission/sql"
  12. import { PermissionSaved } from "@opencode-ai/core/permission/saved"
  13. import { Project } from "@opencode-ai/core/project"
  14. import { ProjectTable } from "@opencode-ai/core/project/sql"
  15. import { AbsolutePath } from "@opencode-ai/core/schema"
  16. import { Session } from "@opencode-ai/core/session"
  17. import { SessionTable } from "@opencode-ai/core/session/sql"
  18. import { SessionStore } from "@opencode-ai/core/session/store"
  19. import { eq } from "drizzle-orm"
  20. import { location } from "./fixture/location"
  21. import { testEffect } from "./lib/effect"
  22. const current = Layer.succeed(
  23. Location.Service,
  24. Location.Service.of(location({ directory: AbsolutePath.make("/project") })),
  25. )
  26. const it = testEffect(
  27. AppNodeBuilder.build(
  28. LayerNode.group([
  29. Database.node,
  30. Bus.node,
  31. SessionStore.node,
  32. PermissionSaved.node,
  33. Agent.node,
  34. Permission.node,
  35. ]),
  36. [[Location.node, current]],
  37. ),
  38. )
  39. function setup(rules: Permission.Ruleset = []) {
  40. return Effect.gen(function* () {
  41. const { db } = yield* Database.Service
  42. yield* db
  43. .insert(ProjectTable)
  44. .values({ id: Project.ID.global, worktree: AbsolutePath.make("/project"), sandboxes: [] })
  45. .onConflictDoNothing()
  46. .run()
  47. .pipe(Effect.orDie)
  48. yield* db
  49. .insert(SessionTable)
  50. .values({
  51. id: Session.ID.make("ses_test"),
  52. project_id: Project.ID.global,
  53. slug: "test",
  54. directory: "/project",
  55. title: "test",
  56. version: "test",
  57. agent: "test",
  58. })
  59. .onConflictDoNothing()
  60. .run()
  61. .pipe(Effect.orDie)
  62. yield* setRules(rules)
  63. })
  64. }
  65. function setRules(rules: Permission.Ruleset) {
  66. return Effect.gen(function* () {
  67. const agents = yield* Agent.Service
  68. yield* agents.transform((editor) =>
  69. editor.update(Agent.ID.make("test"), (agent) => {
  70. agent.permissions = [...rules]
  71. }),
  72. )
  73. })
  74. }
  75. function assertion(input: Partial<Permission.AssertInput> = {}) {
  76. return {
  77. id: Permission.ID.create("per_test"),
  78. sessionID: Session.ID.make("ses_test"),
  79. action: "read",
  80. resources: ["src/index.ts"],
  81. ...input,
  82. } satisfies Permission.AssertInput
  83. }
  84. function waitForRequest() {
  85. return Effect.gen(function* () {
  86. const service = yield* Permission.Service
  87. const bus = yield* Bus.Service
  88. const asked = yield* Deferred.make<Permission.Request>()
  89. const unsubscribe = yield* bus.listen((event) =>
  90. event.type === Permission.Event.Asked.type
  91. ? Deferred.succeed(asked, event.data as Permission.Request).pipe(Effect.asVoid)
  92. : Effect.void,
  93. )
  94. yield* Effect.addFinalizer(() => unsubscribe)
  95. const fiber = yield* service.assert(assertion()).pipe(Effect.forkScoped)
  96. const request = yield* Deferred.await(asked)
  97. return { service, fiber, request }
  98. })
  99. }
  100. describe("Permission", () => {
  101. it.effect("returns the evaluated effect and only queues prompts", () =>
  102. Effect.gen(function* () {
  103. yield* setup([{ action: "read", resource: "*", effect: "allow" }])
  104. const service = yield* Permission.Service
  105. expect(yield* service.ask(assertion())).toEqual({ id: Permission.ID.create("per_test"), effect: "allow" })
  106. expect(yield* service.list()).toEqual([])
  107. yield* setRules([{ action: "read", resource: "*", effect: "deny" }])
  108. expect(yield* service.ask(assertion())).toEqual({ id: Permission.ID.create("per_test"), effect: "deny" })
  109. expect(yield* service.list()).toEqual([])
  110. yield* setRules([])
  111. expect(yield* service.ask(assertion())).toEqual({ id: Permission.ID.create("per_test"), effect: "ask" })
  112. expect(yield* service.get(Permission.ID.create("per_test"))).toBeDefined()
  113. }),
  114. )
  115. it.effect("evaluates against an explicit provider-turn agent", () =>
  116. Effect.gen(function* () {
  117. yield* setup([{ action: "read", resource: "*", effect: "allow" }])
  118. const agents = yield* Agent.Service
  119. yield* agents.transform((editor) =>
  120. editor.update(Agent.ID.make("reviewer"), (agent) => {
  121. agent.permissions.push({ action: "read", resource: "*", effect: "deny" })
  122. }),
  123. )
  124. const service = yield* Permission.Service
  125. expect(yield* service.ask(assertion())).toMatchObject({ effect: "allow" })
  126. expect(yield* service.ask(assertion({ agent: Agent.ID.make("reviewer") }))).toMatchObject({ effect: "deny" })
  127. yield* agents.transform((editor) =>
  128. editor.update(Agent.ID.make("reviewer"), (agent) => {
  129. agent.permissions = []
  130. }),
  131. )
  132. expect(yield* service.ask(assertion({ agent: Agent.ID.make("reviewer") }))).toMatchObject({ effect: "ask" })
  133. expect(yield* service.get(Permission.ID.create("per_test"))).not.toHaveProperty("agent")
  134. }),
  135. )
  136. it.effect("allows and denies from explicit rules without asking", () =>
  137. Effect.gen(function* () {
  138. yield* setup([{ action: "read", resource: "*", effect: "allow" }])
  139. const service = yield* Permission.Service
  140. yield* service.assert(assertion())
  141. yield* setRules([{ action: "read", resource: "*", effect: "deny" }])
  142. const blocked = yield* service.assert(assertion()).pipe(Effect.flip)
  143. expect(blocked).toBeInstanceOf(Permission.BlockedError)
  144. expect(yield* service.list()).toEqual([])
  145. }),
  146. )
  147. it.effect("allows managed output reads without granting external directory access", () =>
  148. Effect.gen(function* () {
  149. yield* setup([
  150. { action: "*", resource: "*", effect: "deny" },
  151. { action: "read", resource: "*", effect: "allow" },
  152. ])
  153. const service = yield* Permission.Service
  154. expect(yield* service.ask(assertion({ resources: ["tool_123"] }))).toMatchObject({ effect: "allow" })
  155. expect(
  156. yield* service.ask(assertion({ action: "external_directory", resources: ["/tmp/tool-output/*"] })),
  157. ).toMatchObject({ effect: "deny" })
  158. }),
  159. )
  160. it.effect("uses build permissions when the Session agent is omitted", () =>
  161. Effect.gen(function* () {
  162. yield* setup()
  163. const { db } = yield* Database.Service
  164. yield* db
  165. .update(SessionTable)
  166. .set({ agent: null })
  167. .where(eq(SessionTable.id, Session.ID.make("ses_test")))
  168. .run()
  169. .pipe(Effect.orDie)
  170. const agents = yield* Agent.Service
  171. yield* agents.transform((editor) =>
  172. editor.update(Agent.ID.make("build"), (agent) => {
  173. agent.permissions = [{ action: "custom", resource: "*", effect: "allow" }]
  174. }),
  175. )
  176. const service = yield* Permission.Service
  177. expect(yield* service.ask(assertion({ action: "custom", resources: ["*"] }))).toEqual({
  178. id: Permission.ID.create("per_test"),
  179. effect: "allow",
  180. })
  181. expect(yield* service.list()).toEqual([])
  182. }),
  183. )
  184. it.effect("denies omitted-agent permissions when no primary default agent exists", () =>
  185. Effect.gen(function* () {
  186. yield* setup()
  187. const { db } = yield* Database.Service
  188. yield* db
  189. .update(SessionTable)
  190. .set({ agent: null })
  191. .where(eq(SessionTable.id, Session.ID.make("ses_test")))
  192. .run()
  193. .pipe(Effect.orDie)
  194. const agents = yield* Agent.Service
  195. yield* agents.transform((editor) => {
  196. editor.remove(Agent.ID.make("test"))
  197. editor.remove(Agent.ID.make("build"))
  198. })
  199. const service = yield* Permission.Service
  200. expect(yield* service.ask(assertion())).toEqual({ id: Permission.ID.create("per_test"), effect: "deny" })
  201. expect(yield* service.list()).toEqual([])
  202. }),
  203. )
  204. it.effect("evaluates bash with the normal configured-rule semantics", () =>
  205. Effect.gen(function* () {
  206. yield* setup([{ action: "*", resource: "*", effect: "allow" }])
  207. const service = yield* Permission.Service
  208. const bash = assertion({ action: "bash", resources: ["pwd"] })
  209. expect(yield* service.ask(bash)).toEqual({ id: Permission.ID.create("per_test"), effect: "allow" })
  210. yield* setRules([])
  211. expect(yield* service.ask(bash)).toEqual({ id: Permission.ID.create("per_test"), effect: "ask" })
  212. expect(yield* service.get(Permission.ID.create("per_test"))).toBeDefined()
  213. }),
  214. )
  215. it.effect("uses saved bash approvals while preserving configured deny precedence", () =>
  216. Effect.gen(function* () {
  217. yield* setup()
  218. const saved = yield* PermissionSaved.Service
  219. yield* saved.add({ projectID: Project.ID.global, action: "bash", resources: ["pwd"] })
  220. const service = yield* Permission.Service
  221. expect(yield* service.ask(assertion({ action: "bash", resources: ["pwd"] }))).toEqual({
  222. id: Permission.ID.create("per_test"),
  223. effect: "allow",
  224. })
  225. expect(yield* service.list()).toEqual([])
  226. yield* setRules([{ action: "bash", resource: "*", effect: "deny" }])
  227. expect(yield* service.ask(assertion({ action: "bash", resources: ["pwd"] }))).toEqual({
  228. id: Permission.ID.create("per_test"),
  229. effect: "deny",
  230. })
  231. }),
  232. )
  233. it.effect("resolves an asked permission once", () =>
  234. Effect.gen(function* () {
  235. yield* setup()
  236. const { service, fiber, request } = yield* waitForRequest()
  237. expect(yield* service.list()).toEqual([request])
  238. expect(yield* service.forSession(request.sessionID)).toEqual([request])
  239. expect(yield* service.forSession(Session.ID.make("ses_other"))).toEqual([])
  240. expect(yield* service.get(request.id)).toEqual(request)
  241. yield* service.reply({ requestID: request.id, reply: "once" })
  242. yield* Fiber.join(fiber)
  243. expect(yield* service.list()).toEqual([])
  244. expect(yield* service.get(request.id)).toBeUndefined()
  245. }),
  246. )
  247. it.effect("defects when an asked permission is declined", () =>
  248. Effect.gen(function* () {
  249. yield* setup()
  250. const { service, fiber, request } = yield* waitForRequest()
  251. yield* service.reply({ requestID: request.id, reply: "reject" })
  252. const exit = yield* Fiber.await(fiber)
  253. expect(exit._tag).toBe("Failure")
  254. if (exit._tag === "Failure")
  255. expect(
  256. exit.cause.reasons.some(
  257. (reason) => Cause.isDieReason(reason) && reason.defect instanceof Permission.DeclinedError,
  258. ),
  259. ).toBe(true)
  260. expect(yield* service.list()).toEqual([])
  261. }),
  262. )
  263. it.effect("stores and removes saved resources for a project", () =>
  264. Effect.gen(function* () {
  265. yield* setup()
  266. const service = yield* Permission.Service
  267. const asked = yield* Deferred.make<Permission.Request>()
  268. const bus = yield* Bus.Service
  269. const unsubscribe = yield* bus.listen((event) =>
  270. event.type === Permission.Event.Asked.type
  271. ? Deferred.succeed(asked, event.data as Permission.Request).pipe(Effect.asVoid)
  272. : Effect.void,
  273. )
  274. yield* Effect.addFinalizer(() => unsubscribe)
  275. const fiber = yield* service.assert(assertion({ save: ["src/*"] })).pipe(Effect.forkScoped)
  276. const request = yield* Deferred.await(asked)
  277. yield* service.reply({ requestID: request.id, reply: "always" })
  278. yield* Fiber.join(fiber)
  279. const { db } = yield* Database.Service
  280. expect(
  281. yield* db.select().from(PermissionTable).where(eq(PermissionTable.project_id, Project.ID.global)).all(),
  282. ).toMatchObject([{ action: "read", resource: "src/*" }])
  283. const saved = yield* PermissionSaved.Service
  284. const id = (yield* saved.list())[0]!.id
  285. expect(yield* saved.list()).toEqual([{ id, projectID: Project.ID.global, action: "read", resource: "src/*" }])
  286. yield* service.assert(assertion({ id: Permission.ID.create("per_next"), resources: ["src/next.ts"] }))
  287. yield* saved.remove(id)
  288. expect(yield* saved.list()).toEqual([])
  289. }),
  290. )
  291. })