tool-question.test.ts 8.8 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268
  1. import { describe, expect } from "bun:test"
  2. import { Cause, Effect, Exit, Fiber, Layer } from "effect"
  3. import { AppNodeBuilder } from "@opencode-ai/core/effect/app-node-builder"
  4. import { LayerNode } from "@opencode-ai/util/effect/layer-node"
  5. import { Form } from "@opencode-ai/core/form"
  6. import { Permission } from "@opencode-ai/core/permission"
  7. import { Session } from "@opencode-ai/core/session"
  8. import { Tool } from "@opencode-ai/core/tool"
  9. import { QuestionTool } from "@opencode-ai/core/tool/plugin/question"
  10. import { Image } from "@opencode-ai/core/image"
  11. import { testEffect } from "./lib/effect"
  12. import { imagePassthrough } from "./lib/image"
  13. import { permissionLayer } from "./lib/permission"
  14. import { makeLocationNode } from "@opencode-ai/util/effect/app-node"
  15. import { toolIdentity, executeTool, registerToolPlugin, toolDefinitions } from "./lib/tool"
  16. const sessionID = Session.ID.make("ses_question_tool_test")
  17. const assertions: Permission.AssertInput[] = []
  18. let captured: Form.CreateInput | undefined
  19. let reject = false
  20. let deny = false
  21. const capturedInput = () => captured
  22. const questionInput = {
  23. questions: [
  24. {
  25. question: "Continue?",
  26. header: "Continue",
  27. options: [{ label: "Yes", description: "Continue" }],
  28. },
  29. ],
  30. }
  31. const permission = permissionLayer({
  32. assert: (input) =>
  33. Effect.sync(() => assertions.push(input)).pipe(
  34. Effect.andThen(
  35. deny
  36. ? Effect.fail(
  37. new Permission.BlockedError({
  38. rules: [],
  39. permission: input.action,
  40. resources: input.resources,
  41. }),
  42. )
  43. : Effect.void,
  44. ),
  45. ),
  46. })
  47. const form = Layer.succeed(
  48. Form.Service,
  49. Form.Service.of({
  50. ask: (input: Form.CreateInput) =>
  51. Effect.sync(() => {
  52. captured = input
  53. }).pipe(
  54. Effect.andThen(
  55. Effect.sync(
  56. (): Form.TerminalState =>
  57. reject ? { status: "cancelled" } : { status: "answered", answer: { q0: "Build", q1: ["Dev"] } },
  58. ),
  59. ),
  60. ),
  61. create: () => Effect.die("unused"),
  62. get: () => Effect.die("unused"),
  63. list: () => Effect.die("unused"),
  64. state: () => Effect.die("unused"),
  65. reply: () => Effect.die("unused"),
  66. cancel: () => Effect.die("unused"),
  67. }),
  68. )
  69. const questionToolNode = makeLocationNode({
  70. name: "test/question-tool-plugin",
  71. layer: Layer.effectDiscard(registerToolPlugin(QuestionTool.Plugin)),
  72. deps: [Tool.node, Permission.node, Form.node],
  73. })
  74. const it = testEffect(
  75. AppNodeBuilder.build(LayerNode.group([Tool.node, questionToolNode]), [
  76. [Permission.node, permission],
  77. [Form.node, form],
  78. [Image.node, imagePassthrough],
  79. ]),
  80. )
  81. describe("QuestionTool", () => {
  82. it.effect("emits one item schema for the nonempty questions array", () =>
  83. Effect.gen(function* () {
  84. captured = undefined
  85. const registry = yield* Tool.Service
  86. const definition = (yield* toolDefinitions(registry)).find((tool) => tool.name === QuestionTool.name)
  87. expect(definition?.inputSchema).toHaveProperty("properties.questions.type", "array")
  88. expect(definition?.inputSchema).toHaveProperty("properties.questions.minItems", 1)
  89. expect(definition?.inputSchema).toHaveProperty("properties.questions.items")
  90. expect(definition?.inputSchema).not.toHaveProperty("properties.questions.prefixItems")
  91. expect(
  92. yield* executeTool(registry, {
  93. sessionID,
  94. ...toolIdentity,
  95. call: { type: "tool-call", id: "call-question-empty", name: QuestionTool.name, input: { questions: [] } },
  96. }),
  97. ).toMatchObject({
  98. status: "error",
  99. error: { type: "tool.execution", message: expect.stringContaining("Invalid tool input") },
  100. })
  101. expect(capturedInput()).toBeUndefined()
  102. }),
  103. )
  104. it.effect("omits a catalog-denied question and enforces its leaf permission", () =>
  105. Effect.gen(function* () {
  106. captured = undefined
  107. deny = true
  108. const registry = yield* Tool.Service
  109. expect(
  110. (yield* toolDefinitions(registry, [{ action: "question", resource: "*", effect: "deny" }])).map(
  111. (tool) => tool.name,
  112. ),
  113. ).toEqual(["execute"])
  114. expect(
  115. yield* executeTool(registry, {
  116. sessionID,
  117. ...toolIdentity,
  118. call: { type: "tool-call", id: "call-question-denied", name: "question", input: questionInput },
  119. }),
  120. ).toEqual({
  121. status: "error",
  122. error: {
  123. type: "permission.rejected",
  124. message: "Permission denied: question",
  125. },
  126. })
  127. expect(capturedInput()).toBeUndefined()
  128. deny = false
  129. }),
  130. )
  131. it.effect("registers question and projects user answers without a permission assertion", () =>
  132. Effect.gen(function* () {
  133. assertions.length = 0
  134. captured = undefined
  135. reject = false
  136. deny = false
  137. const registry = yield* Tool.Service
  138. const questions = [
  139. {
  140. question: "What should happen?",
  141. header: "Action",
  142. options: [{ label: "Build", description: "Build it" }],
  143. },
  144. {
  145. question: "Which environment?",
  146. header: "Environment",
  147. options: [{ label: "Dev", description: "Development" }],
  148. multiple: true,
  149. },
  150. {
  151. question: "Anything else?",
  152. header: "Optional",
  153. options: [],
  154. },
  155. ]
  156. expect((yield* toolDefinitions(registry)).map((definition) => definition.name)).toEqual(["question", "execute"])
  157. expect(
  158. yield* executeTool(registry, {
  159. sessionID,
  160. ...toolIdentity,
  161. call: { type: "tool-call", id: "call-question", name: "question", input: { questions } },
  162. }),
  163. ).toEqual({
  164. status: "completed",
  165. output: { answers: [["Build"], ["Dev"], []] },
  166. content: [
  167. {
  168. type: "text",
  169. text: 'User has answered your questions: "What should happen?"="Build", "Which environment?"="Dev", "Anything else?"="Unanswered". You can now continue with the user\'s answers in mind.',
  170. },
  171. ],
  172. metadata: { answers: [["Build"], ["Dev"], []] },
  173. })
  174. expect(assertions).toMatchObject([{ sessionID, action: "question", resources: ["*"] }])
  175. expect(capturedInput()).toEqual({
  176. sessionID,
  177. title: "Questions",
  178. metadata: { kind: "question", tool: { messageID: toolIdentity.messageID, id: "call-question" } },
  179. fields: [
  180. {
  181. key: "q0",
  182. title: "Action",
  183. description: "What should happen?",
  184. options: [{ value: "Build", label: "Build", description: "Build it" }],
  185. custom: true,
  186. type: "string",
  187. },
  188. {
  189. key: "q1",
  190. title: "Environment",
  191. description: "Which environment?",
  192. options: [{ value: "Dev", label: "Dev", description: "Development" }],
  193. custom: true,
  194. type: "multiselect",
  195. },
  196. {
  197. key: "q2",
  198. title: "Optional",
  199. description: "Anything else?",
  200. options: [],
  201. custom: true,
  202. type: "string",
  203. },
  204. ],
  205. })
  206. }),
  207. )
  208. it.effect("does not invent tool ownership metadata without a durable registry source", () =>
  209. Effect.gen(function* () {
  210. captured = undefined
  211. reject = false
  212. deny = false
  213. const registryService = yield* Tool.Service
  214. yield* executeTool(registryService, {
  215. sessionID,
  216. ...toolIdentity,
  217. call: { type: "tool-call", id: "call-question", name: "question", input: questionInput },
  218. })
  219. expect(capturedInput()).toEqual({
  220. sessionID,
  221. title: "Questions",
  222. metadata: { kind: "question", tool: { messageID: toolIdentity.messageID, id: "call-question" } },
  223. fields: [
  224. {
  225. key: "q0",
  226. title: "Continue",
  227. description: "Continue?",
  228. options: [{ value: "Yes", label: "Yes", description: "Continue" }],
  229. custom: true,
  230. type: "string",
  231. },
  232. ],
  233. })
  234. }),
  235. )
  236. it.effect("keeps dismissed questions out of model-facing output", () =>
  237. Effect.gen(function* () {
  238. captured = undefined
  239. reject = true
  240. deny = false
  241. const registryService = yield* Tool.Service
  242. const fiber = yield* executeTool(registryService, {
  243. sessionID,
  244. ...toolIdentity,
  245. call: { type: "tool-call", id: "call-question", name: "question", input: questionInput },
  246. }).pipe(Effect.forkScoped)
  247. const exit = yield* Fiber.await(fiber)
  248. expect(Exit.isFailure(exit)).toBe(true)
  249. if (Exit.isFailure(exit)) {
  250. const error = Cause.squash(exit.cause)
  251. expect(error).toBeInstanceOf(QuestionTool.CancelledError)
  252. expect(error).toHaveProperty("message", "The user dismissed this question")
  253. }
  254. }),
  255. )
  256. })