review-tab-switch.spec.ts 5.2 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147
  1. import { base64Encode } from "@opencode-ai/core/util/encode"
  2. import { expect, test, type Page } from "@playwright/test"
  3. import { mockOpenCodeServer } from "../utils/mock-server"
  4. import { expectAppVisible, expectSessionTitle } from "../utils/waits"
  5. const directory = "C:/OpenCode/ReviewTabSwitch"
  6. const projectID = "proj_review_tab_switch"
  7. const sessionA = "ses_review_tab_a"
  8. const sessionB = "ses_review_tab_b"
  9. const titleA = "Alpha session"
  10. const titleB = "Beta session"
  11. const server = `http://${process.env.PLAYWRIGHT_SERVER_HOST ?? "127.0.0.1"}:${process.env.PLAYWRIGHT_SERVER_PORT ?? "4096"}`
  12. const diffs = Array.from({ length: 2_740 }, (_, index) =>
  13. fileDiff(`src/generated-${String(index).padStart(4, "0")}.ts`),
  14. )
  15. // Marks the review pane DOM node so a remount (fresh node) is detectable.
  16. const PROBE = "original"
  17. test.use({ viewport: { width: 1440, height: 900 } })
  18. // The v2 review pane's diff data is workspace-scoped: switching between session
  19. // tabs in the same workspace must update its parameters reactively instead of
  20. // tearing the pane down and remounting it (which flickers).
  21. test("keeps the v2 review pane mounted when switching session tabs in a workspace", async ({ page }) => {
  22. await setup(page)
  23. await page.goto(sessionHref(sessionA))
  24. await expectSessionTitle(page, titleA)
  25. await page.getByRole("button", { name: "Toggle review" }).click()
  26. const reviewTab = page.locator("#session-side-panel-review-tab")
  27. const reviewTabPanel = page.locator("#session-side-panel-review-tabpanel")
  28. await expect(reviewTab).toHaveAttribute("aria-controls", "session-side-panel-review-tabpanel")
  29. await expect(reviewTabPanel).toHaveAttribute("id", "session-side-panel-review-tabpanel")
  30. const review = page.locator('#review-panel [data-component="session-review-v2"]')
  31. await expectAppVisible(review)
  32. await expectAppVisible(page.getByRole("button", { name: "generated-0000.ts" }))
  33. await writeProbe(page)
  34. await switchTab(page, titleB)
  35. await expectSessionTitle(page, titleB)
  36. await expectAppVisible(review)
  37. await expectAppVisible(page.getByRole("button", { name: "generated-0000.ts" }))
  38. expect(await readProbe(page)).toBe(PROBE)
  39. await switchTab(page, titleA)
  40. await expectSessionTitle(page, titleA)
  41. await expectAppVisible(review)
  42. await expectAppVisible(page.getByRole("button", { name: "generated-0000.ts" }))
  43. expect(await readProbe(page)).toBe(PROBE)
  44. const viewport = page.locator('#review-panel [data-slot="session-review-v2-sidebar-tree"] .scroll-view__viewport')
  45. await viewport.hover()
  46. await page.mouse.wheel(0, 100_000)
  47. await expect
  48. .poll(() => viewport.evaluate((element) => element.scrollHeight - element.clientHeight - element.scrollTop))
  49. .toBeLessThanOrEqual(1)
  50. await expect(page.getByRole("button", { name: "generated-2739.ts" })).toBeVisible()
  51. })
  52. type Probed = HTMLElement & { __e2eProbe?: string }
  53. async function switchTab(page: Page, title: string) {
  54. await page.locator("[data-titlebar-tab-slot]", { hasText: title }).click()
  55. }
  56. async function writeProbe(page: Page) {
  57. await page.locator('#review-panel [data-component="session-review-v2"]').evaluate((el, probe) => {
  58. ;(el as Probed).__e2eProbe = probe
  59. }, PROBE)
  60. }
  61. async function readProbe(page: Page) {
  62. return page.locator('#review-panel [data-component="session-review-v2"]').evaluate((el) => (el as Probed).__e2eProbe)
  63. }
  64. async function setup(page: Page) {
  65. await mockOpenCodeServer(page, {
  66. directory,
  67. project: {
  68. id: projectID,
  69. worktree: directory,
  70. vcs: "git",
  71. name: "review-tab-switch",
  72. time: { created: 1700000000000, updated: 1700000000000 },
  73. sandboxes: [],
  74. },
  75. provider: {
  76. all: [
  77. {
  78. id: "opencode",
  79. name: "OpenCode",
  80. models: { test: { id: "test", name: "Test", limit: { context: 200_000 } } },
  81. },
  82. ],
  83. connected: ["opencode"],
  84. default: { providerID: "opencode", modelID: "test" },
  85. },
  86. sessions: [session(sessionA, titleA, 1700000000000), session(sessionB, titleB, 1700000001000)],
  87. vcsDiff: diffs,
  88. pageMessages: () => ({ items: [] }),
  89. })
  90. await page.addInitScript(
  91. ({ directory, server, sessions }) => {
  92. localStorage.setItem("settings.v3", JSON.stringify({ general: { newLayoutDesigns: true } }))
  93. localStorage.setItem(
  94. "opencode.global.dat:server",
  95. JSON.stringify({
  96. projects: { local: [{ worktree: directory, expanded: true }] },
  97. lastProject: { local: directory },
  98. }),
  99. )
  100. localStorage.setItem(
  101. "opencode.window.browser.dat:tabs",
  102. JSON.stringify(sessions.map((sessionId: string) => ({ type: "session", server, sessionId }))),
  103. )
  104. },
  105. { directory, server, sessions: [sessionA, sessionB] },
  106. )
  107. }
  108. function session(id: string, title: string, created: number) {
  109. return {
  110. id,
  111. slug: id,
  112. projectID,
  113. directory,
  114. title,
  115. version: "dev",
  116. time: { created, updated: created },
  117. }
  118. }
  119. function sessionHref(sessionID: string) {
  120. return `/server/${base64Encode(server)}/session/${sessionID}`
  121. }
  122. function fileDiff(file: string) {
  123. return {
  124. file,
  125. additions: 1,
  126. deletions: 1,
  127. status: "modified",
  128. patch: `diff --git a/${file} b/${file}\n--- a/${file}\n+++ b/${file}\n@@ -1 +1 @@\n-export const value = 'before'\n+export const value = 'after'\n`,
  129. }
  130. }